-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: improve subcommand app_stat and nodes #277
Conversation
for (int i = 0; i < partitions.size(); i++) { | ||
const dsn::partition_configuration &p = partitions[i]; | ||
if (!p.primary.is_invalid()) { | ||
auto find = tmp_map.find(p.primary); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find
改下名字? 一是跟函数find重名,二是不知道啥内容
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还有几个地方用的find
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个问题不大,我一直都是这么写的
Former-commit-id: c459eebd8ef3f8aca5a2fe4abee23fd4edf2fd3b [formerly ea490d3] Former-commit-id: 125bed9901bb1c05c4e405cae0b19b79a46160be
for app_stat:
rdb_mem_mb
tomem_tbl_mb
andmem_idx_mb
.for nodes:
-r|--resolve_ip
option.-u|--resource_usage
option to add columns:memused_res_mb
,block_cache_mb
,mem_tbl_mb mem_idx_mb
,disk_avl_total_ratio
,disk_avl_min_ratio
.